test: Use single instance of integration_config.yaml when running testall command #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when running testall script
ykim-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
|
@ykim-1 For some reason it's still failing with the same error after the submodule change 🤔 |
lgarber-akamai
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Using
testall.shscript to run tests in parallel rewroteintegration_config.yamlfile which caused the tests to be flaky at times with e2e cloud firewall.Changes have been made to
test_all.shscript to create a single instance of the config yaml fileMoved all e2e related script to submodule as well with this PR
✔️ How to Test
make testallForked run on integration workflow - https://github.com/ykim-1/ansible_linode/actions/runs/9666456836
Forked run on PR integration workflow - https://github.com/ykim-1/ansible_linode/actions/runs/9666887657/job/26667419997
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.