-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Support for Multicluster OBJ in object_keys module #531
new: Support for Multicluster OBJ in object_keys module #531
Conversation
) | ||
except Exception as exception: | ||
return self.fail( | ||
msg="failed to create object storage key: {0}".format(exception) | ||
) | ||
|
||
@staticmethod | ||
def _access_changed(key: ObjectStorageKeys, params: Dict[str, Any]) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method contains a lot of logic just to raise an error, but I really wanted to make sure users would be informed if they attempted to update the bucket access configuration of a key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks for adding these new features!
Co-authored-by: Zhiwei Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
📝 Description
This pull request implements all of the changes to the
object_keys
module for Multicluster OBJ, including:regions
fieldbucket_access.*.region
fieldobject_keys_basic
integration test✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install
.Integration Testing
Manual Testing