Implemented changes for Linode Disk Encryption #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
force-pushed
the
TPT-2890-lde-changes
branch
5 times, most recently
from
93c829b to
8a3a1d0
Compare
ezilber-akamai
force-pushed
the
TPT-2890-lde-changes
branch
from
8a3a1d0 to
08d2d4e
Compare
ezilber-akamai
added
the
do-not-merge
ezilber-akamai
force-pushed
the
TPT-2890-lde-changes
branch
from
64cd869 to
855a6ed
Compare
ezilber-akamai
removed
the
do-not-merge
ezilber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
ezilber-akamai
added
the
do-not-merge
yec-akamai
reviewed
Aug 6, 2024
|
I can't share the spec doc on github for security reason. Let's take the discussion offline! |
yec-akamai
approved these changes
Aug 15, 2024
ezilber-akamai
removed
the
do-not-merge
ezilber-akamai
added
do-not-merge
ezilber-akamai
force-pushed
the
TPT-2890-lde-changes
branch
2 times, most recently
from
bbf73d8 to
0cfc7d6
Compare
lgarber-akamai
approved these changes
Aug 27, 2024
ezilber-akamai
added a commit
that referenced
this pull request
Aug 28, 2024
This reverts commit 19fb287.
ezilber-akamai
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Updated ansible modules to consume changes according to the API Spec (can be found in the ticket).
✔️ How to Test
Integration Tests
make TEST_ARGS="-v instance_disk_encryption" testmake TEST_ARGS="-v lke_cluster_basic" testmake TEST_ARGS="-v lke_node_pool_basic" test