test: Improve E2E test firewall creation and teardown #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Here are some improvements around creation and deletion of E2E Test Firewall:
✔️ How to Test
git submodule update --init
may be required if submodule directory isn't downloaded locallyVerifying error handling when firewall creation fails:
make create-e2e-firewall
Verifying proper teardown when test execution fails:
make TEST_ARGS="-v domain_basic" test
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.