ref: Migrate profile_info to use common info module
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
added
the
improvement
yec-akamai
requested review from
jriddle-linode and
ezilber-akamai
and removed request for
a team
yec-akamai
commented
Aug 9, 2024
Comment on lines
-223
to
+243
| attribute_names = [v.name for v in self.attributes] | ||
| attribute_names = ( | ||
| [[v.name for v in self.attributes]] | ||
| if len(self.attributes) > 0 | ||
| else None | ||
| ) | ||
|
|
||
| super().__init__( | ||
| module_arg_spec=self.module_arg_spec, | ||
| required_one_of=[attribute_names], | ||
| mutually_exclusive=[attribute_names], | ||
| required_one_of=attribute_names, | ||
| mutually_exclusive=attribute_names, |
There was a problem hiding this comment.
The previous implementation brought an edge case that when the module didn't require any attribute, we still send an [[]] value as required_one_of. It caused a bug to fail the module.
ezilber-akamai
approved these changes
Aug 13, 2024
jriddle-linode
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrate
profile_infoto use common info module. Also make some necessary change to the base info module because profile_info doesn't require any attribute or parameter to call.✔️ How to Test
make TEST_ARGS="-v profile_info" testManual test: