Add useIsNodebalancerVPCEnabled() hook and test coverage; fix flag na…

…me from nodebalancerVPC --> nodebalancerVpc
linode · Feb 28, 2025 · 01f5db4 · 01f5db4
1 parent e878bb4
commit 01f5db4
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 2 deletions.
diff --git a/packages/manager/src/dev-tools/FeatureFlagTool.tsx b/packages/manager/src/dev-tools/FeatureFlagTool.tsx
@@ -28,7 +28,7 @@ const options: { flag: keyof Flags; label: string }[] = [
   { flag: 'linodeDiskEncryption', label: 'Linode Disk Encryption (LDE)' },
   { flag: 'linodeInterfaces', label: 'Linode Interfaces' },
   { flag: 'lkeEnterprise', label: 'LKE-Enterprise' },
-  { flag: 'nodebalancerVPC', label: 'NodeBalancer-VPC Integration' },
+  { flag: 'nodebalancerVpc', label: 'NodeBalancer-VPC Integration' },
   { flag: 'objMultiCluster', label: 'OBJ Multi-Cluster' },
   { flag: 'objectStorageGen2', label: 'OBJ Gen2' },
   { flag: 'selfServeBetas', label: 'Self Serve Betas' },

diff --git a/packages/manager/src/featureFlags.ts b/packages/manager/src/featureFlags.ts
@@ -126,7 +126,7 @@ export interface Flags {
   mainContentBanner: MainContentBanner;
   marketplaceAppOverrides: MarketplaceAppOverride[];
   metadata: boolean;
-  nodebalancerVPC: boolean;
+  nodebalancerVpc: boolean;
   objMultiCluster: boolean;
   objectStorageGen2: BaseFeatureFlag;
   productInformationBanners: ProductInformationBannerFlag[];

diff --git a/packages/manager/src/features/NodeBalancers/utils.test.ts b/packages/manager/src/features/NodeBalancers/utils.test.ts
@@ -0,0 +1,31 @@
+import { renderHook, waitFor } from '@testing-library/react';
+
+import { wrapWithTheme } from 'src/utilities/testHelpers';
+
+import { useIsNodebalancerVPCEnabled } from './utils';
+
+describe('useIsNodebalancerVPCEnabled', () => {
+  it('returns true if the feature is enabled', async () => {
+    const options = { flags: { nodebalancerVpc: true } };
+
+    const { result } = renderHook(() => useIsNodebalancerVPCEnabled(), {
+      wrapper: (ui) => wrapWithTheme(ui, options),
+    });
+
+    await waitFor(() => {
+      expect(result.current.isNodebalancerVPCEnabled).toBe(true);
+    });
+  });
+
+  it('returns false if the feature is NOT enabled', async () => {
+    const options = { flags: { nodebalancerVpc: false } };
+
+    const { result } = renderHook(() => useIsNodebalancerVPCEnabled(), {
+      wrapper: (ui) => wrapWithTheme(ui, options),
+    });
+
+    await waitFor(() => {
+      expect(result.current.isNodebalancerVPCEnabled).toBe(false);
+    });
+  });
+});
diff --git a/packages/manager/src/features/NodeBalancers/utils.ts b/packages/manager/src/features/NodeBalancers/utils.ts
@@ -1,5 +1,6 @@
 import { filter, isNil } from 'ramda';
 
+import { useFlags } from 'src/hooks/useFlags';
 import { getErrorMap } from 'src/utilities/errorUtils';
 
 import {
@@ -211,3 +212,19 @@ export const getStickinessOptions = (protocol: Protocol) => {
     option.supportedProtocols.includes(protocol)
   );
 };
+
+/**
+ * Returns whether or not features related to the NB-VPC project
+ * should be enabled.
+ *
+ * Currently, this just uses the `nodebalancerVPC` feature flag as a source of truth,
+ * but will eventually also look at account capabilities.
+ */
+
+export const useIsNodebalancerVPCEnabled = () => {
+  const flags = useFlags();
+
+  // @TODO NB-VPC: check for customer tag/account capability when it exists
+
+  return { isNodebalancerVPCEnabled: flags.nodebalancerVpc ?? false };
+};