fix: [M3-7811] - Fix Users & Grants query filtering on user_type (#10230

)

* Use an API supported simple filter on one user_type

* Filter on child accounts for proxy user too

* Add changeset

* Use correct number of columns for Business Partner table

packages/manager/.changeset/pr-10230-upcoming-features-1708982538087.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Fix Users & Grants filtering error based on `user_type` ([#10230](https://github.com/linode/manager/pull/10230))

packages/manager/src/features/Users/UsersLanding.tsx

@@ -33,15 +33,16 @@ export const UsersLanding = () => {
   const pagination = usePagination(1, 'account-users');
   const order = useOrder();
 
+  const showProxyUserTable =
+    flags.parentChildAccountAccess &&
+    (profile?.user_type === 'child' || profile?.user_type === 'proxy');
+
   const usersFilter: Filter = {
     ['+order']: order.order,
     ['+order_by']: order.orderBy,
+    ['user_type']: showProxyUserTable ? 'child' : undefined,
   };
 
-  if (flags.parentChildAccountAccess) {
-    usersFilter['user_type'] = { '+neq': 'proxy' };
-  }
-
   const { data: users, error, isLoading, refetch } = useAccountUsers({
     filters: usersFilter,
     params: {
@@ -61,10 +62,6 @@ export const UsersLanding = () => {
 
   const isRestrictedUser = profile?.restricted;
 
-  const showProxyUserTable =
-    flags.parentChildAccountAccess &&
-    (profile?.user_type === 'child' || profile?.user_type === 'proxy');
-
   const showChildAccountAccessCol = Boolean(
     flags.parentChildAccountAccess && profile?.user_type === 'parent'
   );
@@ -100,7 +97,7 @@ export const UsersLanding = () => {
             <UsersLandingTableBody
               error={proxyUserError}
               isLoading={isLoadingProxyUser}
-              numCols={numCols}
+              numCols={4}
               onDelete={handleDelete}
               users={proxyUser?.data}
             />