-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7530] - Restrict proxy users from updating username/email #10103
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jaalah-akamai! Confirmed fields/buttons are disabled when user_type
is proxy
, and that the field/buttons behave as expected for other user_type
s.
packages/manager/src/features/Profile/DisplaySettings/DisplaySettings.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the only a proxy user does see disabled text fields and buttons with a tooltip for username and email. Approving pending a styling regression fix and some small unit test additions.
Thanks for aligning the buttons with the textfields too. When I checked for any styling regressions at various screen sizes, the only thing I found was the smaller width of the textfields, which I don't think was an intended change.
We could improve test coverage just slightly with the suggestions Joe and I left there.
Description 📝
As a parent user logged into a proxy account, I should not be able to change the email address or username set by the provisioning API.
Changes 🔄
/profile/display
page.Username
andEmail
Preview 📷
How to test 🧪
Prerequisites
user_type
toproxy
in serverHandlersReproduction steps
Verification steps
user_type
to something else, observe fields are editableAs an Author I have considered 🤔
Check all that apply