-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7694] - OBJ Multi Cluster Copy updates #10188
Conversation
Coverage Report: ✅ |
I'm not sure this is related, but when going to |
@jaalah-akamai This is handled in the PR #10189 to manage these errors gracefully when the feature flag is on and MSW is off. Once it is merged, we won't see the app crashing when MSW is off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chandra! Confirmed copy changes matched the requested updates, but left a bit of feedback.
This is my first time looking at OBJ Multi-Cluster stuff in a while, so I also wanted to note an unrelated-to-this-PR UI feature that initially confused me:
After creating an access key, when viewing the modal, I thought the "Copy all" button applied to every field (copy the regions, access key, and secret key all at once) because I only had one region and "Copy all" was at the top. After seeing the HostNamesDrawer, I understand that it is intended to copy only the hostnames, of which there can be multiple. Not sure if this would be a common misconception, but might be worth discussing with UX, removing the "Copy all" in this modal, or changing it to "Copy" when there is just one region -- in a separate ticket.
Another minor note here is that the top and bottom padding on this field seem a little too wide.
packages/manager/src/features/ObjectStorage/AccessKeyLanding/LimitedAccessControls.tsx
Outdated
Show resolved
Hide resolved
packages/manager/.changeset/pr-10188-upcoming-features-1707837776464.md
Outdated
Show resolved
Hide resolved
…776464.md Co-authored-by: Mariah Jacobs <[email protected]>
…imitedAccessControls.tsx Co-authored-by: Mariah Jacobs <[email protected]>
Description 📝
Update final copy for OBJ Multi Cluster.
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply