fix: [M3-7758] - Linode Network Graph Tooltip - Incorrect Units #10197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Bug
bnussman-akamai
requested review from
mjac0bs and
abailly-akamai
and removed request for
a team
bnussman-akamai
commented
Feb 15, 2024
| @@ -298,7 +267,7 @@ const Graph = (props: GraphProps) => { | |||
| height={420} | |||
| showLegend | |||
| timezone={timezone} | |||
| unit={' Kb/s'} | |||
| unit={` ${unit}/s`} | |||
There was a problem hiding this comment.
This is the primary fix. We now pass the unit instead of using the hardcoded Kb/s unit.
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Feb 16, 2024
abailly-akamai
approved these changes
Feb 16, 2024
| privateIn: pathOr([], ['data', 'netv6', 'private_in'], stats), | ||
| privateOut: pathOr([], ['data', 'netv6', 'private_out'], stats), | ||
| publicIn: pathOr([], ['data', 'netv6', 'in'], stats), | ||
| publicOut: pathOr([], ['data', 'netv6', 'out'], stats), |
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
In our new Recharts graphs, the tooltip unit would sometimes not match the units that the graph was using. This PR fixes that issue. The graph's units (shown in the graph title), should match what is shown in the tooltip.
Changes 🔄
totalTrafficprop 🗑️Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔