Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7812] Textfield input disabled styles #10231

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Feb 26, 2024

Description 📝

The disabled styles for the textfield input are currently broken, ending up having to impact on the styling when a field is disabled.

I picked the same bg color for disabled state as Radio/Checkboxes for consistency

Changes 🔄

  • Fix theme layer style declaration for Textfield disabled styles
  • Add disabled cursor (UX approved)

Preview 📷

Before After
Screenshot 2024-02-27 at 08 20 00 Screenshot 2024-02-27 at 08 20 00
Screen.Recording.2024-02-27.at.08.17.47.mov

How to test 🧪

Verification steps

  • Confirm the fix to the styles by all/either
    • using storybook or, in context (esp white background)
    • manually change a field to be disabled within the CM UI

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Feb 26, 2024
@abailly-akamai abailly-akamai added the Bug Fixes for regressions or bugs label Feb 26, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review February 26, 2024 22:30
@abailly-akamai abailly-akamai requested a review from a team as a code owner February 26, 2024 22:30
@abailly-akamai abailly-akamai requested review from mjac0bs and hkhalil-akamai and removed request for a team February 26, 2024 22:30
Copy link

github-actions bot commented Feb 26, 2024

Coverage Report:
Base Coverage: 81.34%
Current Coverage: 81.34%

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Feb 27, 2024
@abailly-akamai abailly-akamai merged commit f08d42c into linode:develop Feb 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants