fix: [M3-7508] - Follow up on tests to check Parent and Child 'Close Account' flows #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu-akamai
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team,
dwiley-akamai and
abailly-akamai
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks for addressing the feedback. Test cases and comment look accurate now. Based on comments in the last PR, the suggestion may have been to use CM's constants from src to avoid duplicating the tooltip text, but if there's a reason to avoid that or it can't be done, this seems fine too.
mjac0bs
changed the title
dwiley-akamai
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
account-cancellation.spec.ts passes ✅
I agree re: the use of src/features/Account/constants.ts if possible for the constants (and also renaming the ones in this PR to match the usual casing convention for constants, e.g. PARENT_USER_CLOSE_ACCOUNT_TOOLTIP_TEXT)
bnussman-akamai
pushed a commit
to bnussman-akamai/manager
that referenced
this pull request
Apr 4, 2024
…Account' flows (linode#10316) * M3-7508 Fixed previous PR comments * Added changeset: Add tests to check Parent and Child Close Account flows * Added original PR link * Fix constants
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix the PR comments in previous PR Add tests to check Parent and Child Close Account flows.