-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7861]: Include powered-off data in clone analytics event #10337
upcoming: [M3-7861]: Include powered-off data in clone analytics event #10337
Conversation
@mjac0bs While we wait on changes on the analytics side, I wanted to prototype what custom analytics key-value pairs might look like based on my understanding of the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for prototyping this! As I played with this locally, I actually wasn't seeing the event fire with data
(after I changed it from details
) like I would expect, so I've let Richa know and will follow up with what she says -- I think there's probably still a misconfiguration on the backend because we can do something like this:
In the meantime, I'm leaving some thoughts here.
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good from local testing with the changes in the Adobe dev environment! Approving pending my couple of additional comments re: variable name and tracking isLinodePoweredOff for events other than clone.
Clone with Linode Powered On | Clone with Linode Powered Off |
---|---|
![]() ![]() |
![]() ![]() |
While it takes about 1 hour for event data to show up in the AA dashboard, I did set up a graph in the Linode Cloud - Dev Dashboard and can see that our new custom component data is being associated with their respective click events:
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: β
|
@hkhalil-akamai I'm going to use M3-7964 to update our documentation on Adobe in our developer guide to reflect the latest changes. |
I'm going to go ahead and merge this. e2es failed on the final runner because of the hanging test in |
Description π
Updates the Create Linode analytics event when cloning to include whether the source Linode was powered-off.
Target release date ποΈ
4/15
How to test π§ͺ
REACT_APP_ADOBE_ANALYTICS_URL
is set in your .env_satellite.setDebug(true)
data.isLinodePoweredOff
field reflects the power status of the origin LinodeAs an Author I have considered π€
Check all that apply