Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7861]: Include powered-off data in clone analytics event #10337

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Apr 1, 2024

Description πŸ“

Updates the Create Linode analytics event when cloning to include whether the source Linode was powered-off.

Target release date πŸ—“οΈ

4/15

How to test πŸ§ͺ

  • Enable the Linode Clone UI Feature flag
  • Go to http://localhost:3000 and turn on analytics logs for Adobe:
    • Ensure REACT_APP_ADOBE_ANALYTICS_URL is set in your .env
    • In the browser console, type _satellite.setDebug(true)
  • Clone a powered-on/off Linode
  • Verify the Create Linode event is fired and the data.isLinodePoweredOff field reflects the power status of the origin Linode
  • Optional (it takes about ~1 hr for Adobe dashboards to update):
    • Log into Adobe Analytics
    • Go to the Projects folder and open the Linode Cloud - Dev Dashboard. Scroll down to the bottom two graphs, "Component Details vs. Component Clicks" and "Number of Events With Linodes Powered Off" and observe the data before and ~1 hour after your testing, which should now include metrics for your event(s) that fired.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@hkhalil-akamai
Copy link
Contributor Author

@mjac0bs While we wait on changes on the analytics side, I wanted to prototype what custom analytics key-value pairs might look like based on my understanding of the changes.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for prototyping this! As I played with this locally, I actually wasn't seeing the event fire with data (after I changed it from details) like I would expect, so I've let Richa know and will follow up with what she says -- I think there's probably still a misconfiguration on the backend because we can do something like this:

Screenshot 2024-04-02 at 12 16 01β€―PM

In the meantime, I'm leaving some thoughts here.

@mjac0bs mjac0bs self-requested a review April 8, 2024 16:14
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good from local testing with the changes in the Adobe dev environment! Approving pending my couple of additional comments re: variable name and tracking isLinodePoweredOff for events other than clone.

Clone with Linode Powered On Clone with Linode Powered Off
Screenshot 2024-04-09 at 8 08 18β€―AM Screenshot 2024-04-09 at 8 08 31β€―AM Screenshot 2024-04-09 at 8 10 54β€―AM Screenshot 2024-04-09 at 8 11 08β€―AM

While it takes about 1 hour for event data to show up in the AA dashboard, I did set up a graph in the Linode Cloud - Dev Dashboard and can see that our new custom component data is being associated with their respective click events:
image

@hkhalil-akamai hkhalil-akamai marked this pull request as ready for review April 9, 2024 15:33
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner April 9, 2024 15:33
@hkhalil-akamai hkhalil-akamai requested review from dwiley-akamai and jaalah-akamai and removed request for a team April 9, 2024 15:33
Copy link

github-actions bot commented Apr 9, 2024

Coverage Report: βœ…
Base Coverage: 81.78%
Current Coverage: 81.78%

@mjac0bs
Copy link
Contributor

mjac0bs commented Apr 9, 2024

@hkhalil-akamai I'm going to use M3-7964 to update our documentation on Adobe in our developer guide to reflect the latest changes.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 10, 2024
@mjac0bs
Copy link
Contributor

mjac0bs commented Apr 10, 2024

I'm going to go ahead and merge this. e2es failed on the final runner because of the hanging test in account-switching.spec.ts. This test is a known issue, unrelated to these PR changes.

@mjac0bs mjac0bs merged commit fd83b3a into linode:develop Apr 10, 2024
17 of 18 checks passed
@hkhalil-akamai hkhalil-akamai deleted the M3-7861-clone-linode-analytics branch April 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants