Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip hanging Parent/Child test #10353

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

Observing some weird hanging with one of the Parent/Child tests. Spent some time trying to figure it out but ran out of time, and don't want this interfering with the tests during our next release or during any potential hotfixes (hoping whatever might be causing this isn't already present in staging in case there's a hotfix before our next release -- if this does become an issue). Feel free to merge whenever (or don't if the problem stops happening 🤷‍♂️)

I posted some information about this issue in the notification channel, but I don't have any reason to believe this is caused by a Cloud bug so there shouldn't be any major risk to skipping this temporarily. I will unskip this and figure out the issue when I'm back.

Target release date 🗓️

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before After
📷 📷

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>

Commit Types:

  • feat: New feature for the user (not a part of the code, or ci, ...).
  • fix: Bugfix for the user (not a fix to build something, ...).
  • change: Modifying an existing visual UI instance. Such as a component or a feature.
  • refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
  • test: New tests or changes to existing tests. Does not change the production code.
  • upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history


@jdamore-linode jdamore-linode self-assigned this Apr 4, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner April 4, 2024 21:55
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team April 4, 2024 21:55
Copy link

github-actions bot commented Apr 4, 2024

Coverage Report:
Base Coverage: 81.7%
Current Coverage: 81.7%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the hanging happening again today, so we'll skip and I'll make a ticket (if there isn't one already) to investigate the cause of this farther.

Update: Ticketed in M3-7928.

@mjac0bs mjac0bs merged commit ffa008c into linode:develop Apr 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants