change: [M3-7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint #10505

carrillo-erik · 2024-05-22T17:15:37Z

Description 📝

The changes in this PR replace the hardcoded price values for LKE High Availability with the data from the lke/types endpoint.

Changes 🔄

List any change relevant to the reviewer.

Removal of the LK_HA_PRICE const.
Replacement of outstanding default imports with named imports.
ClusterDetail is renamed to KubernetesClusterDetail.
New kubernetesTypeFactory type factory and corresponding tests.
New DC Specific Pricing queries for Kubernetes (LKE HA).
New lke/types API endpoint.

How to test 🧪

Go through the normal Kubernetes Create workflow.

Verification steps

(How to verify changes)

Verify that existing LKE create workflows behave as expected.
Verify that switching between different regions changes the price. In particular Jakarta, ID (id-cgk) and Sao Paulo, BR (br-gru) should update the price for LKE HA from $60.00 to $72.00 and $84.00, respectively.
Verify that the total price reflects the LKE HA selection based on the appropriate region.
Verify there are no visual regressions as a result of these changes.

As an Author I have considered 🤔

Check all that apply

…ge/M3-7383

github-actions · 2024-05-22T17:39:44Z

Coverage Report: ✅
Base Coverage: 82.85%
Current Coverage: 83.08%

packages/manager/src/factories/types.ts

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/UpgradeClusterDialog.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

carrillo-erik · 2024-05-28T13:11:48Z

Please Note:

Aside from resolving the merge conflicts, there's some optimizations that need to be implemented. There were additional use cases discovered and I'm waiting for input from UX on how to address them. For now, I've labeled this PR as Work in Progress.

abailly-akamai · 2024-05-29T15:22:33Z

~~@carrillo-erik can we resolve the conflict before review?~~

nevermind, just saw the comment above. Maybe back into draft until ready to be reviewed?

…ge/M3-7383

mjac0bs

Here's some initial feedback, @carrillo-erik. Let me know if you have any questions, and thanks for working with Andrew on some of the UX aspects.

packages/manager/.changeset/pr-10505-changed-1716400104404.md

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.test.tsx

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/UpgradeClusterDialog.tsx

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx

…ge/M3-7383

mjac0bs

Thanks for addressing feedback, @carrillo-erik!

Confirmed that I'm seeing loading and error state when expected, and otherwise seeing HA pricing from the API reflected on the Kube create and details pages for normal regions, Jakarta, and Sao Paulo.

Left a few minor comments about some more clean up, but approving pending those are addressed.

packages/manager/src/utilities/pricing/constants.ts

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeSummaryPanel.tsx

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.test.tsx

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.test.tsx

abailly-akamai

Pr looks good overall, so does the UI. great job overall with coding conventions and attention to details providing fallbacks in the UI.

There's a few non blocking items to cleanup, approving pending mine & Mariah's comments

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubernetesClusterDetail.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/UpgradeClusterDialog.tsx

abailly-akamai · 2024-06-11T14:48:16Z

@carrillo-erik i believe the e2e failure also is relevant here, you do want to fix it before merging

…ge/M3-7383

packages/manager/src/factories/linodes.ts

…ge/M3-7383

carrillo-erik · 2024-06-14T12:23:31Z

@abailly-akamai @mjac0bs
There's been a few updates to this PR and it continually got bigger (although the changes were minimal). I'm more than happy to schedule a pair review session before merging this PR.

mjac0bs

LKE pricing looks good after the final suggestions I've left, so approving pending those are addressed. We need to make sure we don't render undefined in the UI while the HA price is loading. (Toggling loading and error state on and off in the RQ dev tools is useful in testing this.)

I'm not seeing any regressions, but I didn't go to every single place that selectedRegionId now can be undefined when it would previously be null or an empty string to make sure that's handled as expected.

packages/manager/src/factories/linodes.ts

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.test.tsx

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.tsx

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx

abailly-akamai · 2024-06-18T13:26:19Z

@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again

…ge/M3-7383

carrillo-erik · 2024-06-18T14:58:18Z

@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again

@abailly-akamai I've pushed my recent changes addressing the feedback.

…m `lke/types` API endpoint (linode#10505) * change: [M3-7383] - Replace hardcoded LKE HA prices with API data * Add changesets * Update HA pricing logic to account for API errors * Revert file back to previous version * Show tooltip as part of radio button label during API error * Implement UX updates to handle error and loading states * Fix ha control plane tests * More changes from PR review * Fix tests (e2e and unit) and update regionId data type and PR feedback * Update highAvailability type and revert update to linode type values

carrillo-erik added 2 commits May 22, 2024 09:55

change: [M3-7383] - Replace hardcoded LKE HA prices with API data

1398bdb

Merge branch 'develop' of https://github.com/linode/manager into chan…

2431c86

…ge/M3-7383

carrillo-erik added the DC-Specific Pricing label May 22, 2024

carrillo-erik self-assigned this May 22, 2024

carrillo-erik requested a review from a team as a code owner May 22, 2024 17:15

carrillo-erik requested review from mjac0bs and abailly-akamai and removed request for a team May 22, 2024 17:15

carrillo-erik changed the title ~~Change/m3 7383~~ change: [M3 7383] - Replace hardcoded prices for LKE HA with data from lke/types API endpoint May 22, 2024

carrillo-erik added the Help Wanted Teamwork makes the dream work! label May 22, 2024

carrillo-erik commented May 22, 2024

View reviewed changes

packages/manager/src/factories/types.ts Outdated Show resolved Hide resolved

carrillo-erik added 2 commits May 22, 2024 10:48

Add changesets

36afc86

Update HA pricing logic to account for API errors

2454a3d

carrillo-erik added Work in Progress and removed Help Wanted Teamwork makes the dream work! labels May 24, 2024

carrillo-erik commented May 24, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx Outdated Show resolved Hide resolved

Revert file back to previous version

2757508

carrillo-erik commented May 24, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx Outdated Show resolved Hide resolved

carrillo-erik commented May 24, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx Outdated Show resolved Hide resolved

Show tooltip as part of radio button label during API error

7bf4b39

carrillo-erik commented May 28, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/UpgradeClusterDialog.tsx Outdated Show resolved Hide resolved

carrillo-erik commented May 28, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/UpgradeClusterDialog.tsx Outdated Show resolved Hide resolved

carrillo-erik commented May 28, 2024

View reviewed changes

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx Outdated Show resolved Hide resolved

carrillo-erik changed the title ~~change: [M3 7383] - Replace hardcoded prices for LKE HA with data from lke/types API endpoint~~ change: [M3-7383] - Replace hardcoded prices for LKE HA with data from lke/types API endpoint Jun 3, 2024

carrillo-erik added 2 commits June 3, 2024 07:39

Merge branch 'develop' of https://github.com/linode/manager into chan…

58dc9f9

…ge/M3-7383

Implement UX updates to handle error and loading states

d09f52a

carrillo-erik requested a review from a team as a code owner June 6, 2024 14:46

carrillo-erik requested review from jdamore-linode and removed request for a team June 6, 2024 14:46

carrillo-erik removed the Work in Progress label Jun 6, 2024

Fix ha control plane tests

fcf27a6

mjac0bs reviewed Jun 7, 2024

View reviewed changes

mjac0bs added the @linode/api-v4 Changes are made to the @linode/api-v4 package label Jun 7, 2024

carrillo-erik added 2 commits June 10, 2024 04:34

Merge branch 'develop' of https://github.com/linode/manager into chan…

8207d90

…ge/M3-7383

More changes from PR review

49d8c5c

carrillo-erik requested a review from mjac0bs June 10, 2024 19:48

mjac0bs approved these changes Jun 10, 2024

View reviewed changes

abailly-akamai approved these changes Jun 11, 2024

View reviewed changes

carrillo-erik added 2 commits June 13, 2024 09:16

Fix tests (e2e and unit) and update regionId data type and PR feedback

1b1badf

Merge branch 'develop' of https://github.com/linode/manager into chan…

805aed3

…ge/M3-7383

mjac0bs self-requested a review June 13, 2024 17:15

carrillo-erik commented Jun 14, 2024

View reviewed changes

packages/manager/src/factories/linodes.ts Outdated Show resolved Hide resolved

Merge branch 'develop' of https://github.com/linode/manager into chan…

7e3486b

…ge/M3-7383

carrillo-erik requested a review from abailly-akamai June 14, 2024 10:59

mjac0bs approved these changes Jun 14, 2024

View reviewed changes

carrillo-erik added 2 commits June 18, 2024 07:09

Merge branch 'develop' of https://github.com/linode/manager into chan…

cc8a22d

…ge/M3-7383

Update highAvailability type and revert update to linode type values

b58f6db

abailly-akamai approved these changes Jun 18, 2024

View reviewed changes

mjac0bs added the Approved Multiple approvals and ready to merge! label Jun 18, 2024

carrillo-erik merged commit 1f2d666 into linode:develop Jun 18, 2024
18 checks passed

This was referenced Jun 21, 2024

Release v1.122.0 - release → staging #10601

Merged

Release v1.122.0 - staging → master #10608

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint #10505

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint #10505

carrillo-erik commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

carrillo-erik commented May 28, 2024

abailly-akamai commented May 29, 2024 •

edited

Loading

mjac0bs left a comment

mjac0bs left a comment

abailly-akamai left a comment

abailly-akamai commented Jun 11, 2024

carrillo-erik commented Jun 14, 2024

mjac0bs left a comment

abailly-akamai commented Jun 18, 2024

carrillo-erik commented Jun 18, 2024

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from lke/types API endpoint #10505

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from lke/types API endpoint #10505

Conversation

carrillo-erik commented May 22, 2024 • edited Loading

Description 📝

Changes 🔄

How to test 🧪

Verification steps

As an Author I have considered 🤔

github-actions bot commented May 22, 2024 • edited Loading

carrillo-erik commented May 28, 2024

Please Note:

abailly-akamai commented May 29, 2024 • edited Loading

mjac0bs left a comment

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

abailly-akamai commented Jun 11, 2024

carrillo-erik commented Jun 14, 2024

mjac0bs left a comment

Choose a reason for hiding this comment

abailly-akamai commented Jun 18, 2024

carrillo-erik commented Jun 18, 2024

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint #10505

change: [M3-7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint #10505

carrillo-erik commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

abailly-akamai commented May 29, 2024 •

edited

Loading