change: Use loading icon to indicate tax id is being verified #10928
Conversation
jaalah-akamai
requested review from
hana-akamai,
carrillo-erik,
hkhalil-akamai and
coliu-akamai
and removed request for
a team,
hana-akamai and
carrillo-erik
jaalah-akamai
changed the title
|
Coverage Report: ✅ |
There was a problem hiding this comment.
Should we also clean up the tax id types/events/etc introduced in #10558?
hana-akamai
added
Approved
We'll still need those 👍 |
It's not great and I made this known. There's a couple options we can do on the frontend to improve the experience while not displaying invalid tax ids on invoices. This will be coming soon, but until then we had to remove this one aspect since the requirements changed slightly and it was no longer accurate |
|
Understood! Thanks @jaalah-akamai |
jaalah-akamai
changed the title
| queryClient.invalidateQueries({ | ||
| queryKey: accountQueries.notifications.queryKey, | ||
| }); |
There was a problem hiding this comment.
Shouldn't be needed, right?
There was a problem hiding this comment.
Initially we were able to rely on events here https://github.com/linode/manager/blob/develop/packages/manager/src/queries/account/billing.ts#L36-L40 but those events are not sent until after verification
…#10928) * change: No longer need to display an icon next to invalid tax ids * Added changeset: Invalid Tax Id Notification * change: add verifying state instead of removing icon - better UX * Update pr-10928-removed-1726148104546.md --------- Co-authored-by: Jaalah Ramos <[email protected]>
Description 📝
We need to verify the tax id before any of the events
tax_id_validortax_id_invalidare fired off. This new icon provides a better UX.See for more details: #10558
Changes 🔄
Target release date 🗓️
9/16
Preview 📷
Include a screenshot or screen recording of the change
Screen.Recording.2024-09-12.at.15.49.10.mov
How to test 🧪
Verification steps
Just observe that removing code does not break anything within the file itself.
As an Author I have considered 🤔
Check all that apply