Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8007] - DBaaS Summary tab display correct user and readonly host #10989

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Sep 23, 2024

Description 📝

DBaaS Summary tab display correct user and readonly host

Changes 🔄

List any change relevant to the reviewer.

  • Display correct username for V2
  • Display correct read-only host for V2

Target release date 🗓️

9/30/24

Preview 📷

Before After
Screenshot 2024-09-23 at 3 12 16 PM Screenshot 2024-09-23 at 3 12 27 PM

How to test 🧪

Prerequisites

  • Managed Databases Beta account capability

Reproduction steps

  • Create new DB
  • Go to summary tab

Verification steps

  • Username is correct
  • readonly host displays

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • [] 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner September 23, 2024 19:14
@corya-akamai corya-akamai requested review from dwiley-akamai and abailly-akamai and removed request for a team September 23, 2024 19:14
@corya-akamai corya-akamai force-pushed the UIE-8007 branch 2 times, most recently from dc9c46f to e7f11d0 Compare September 23, 2024 19:17
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @corya-akamai - looks good to me and confirmed the changes.

I suggested some non-blocking type improvements that would improve type safety for this feature.

@corya-akamai corya-akamai changed the title fix [UIE-8007] DBaaS Summary tab display correct user and readonly host fix: [UIE-8007] - DBaaS Summary tab display correct user and readonly host Sep 24, 2024
@coliu-akamai coliu-akamai added the DBaaS Relates to Database as a Service label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pointing at the dev environment and have the Managed Databases Beta account capability, but I'm seeing the error below whenever I try to get on the DBaaS landing page -- is this happening for others as well?

Screenshot 2024-09-24 at 2 01 40 PM

Also running into issues with provisioning DBs in alpha at the moment, will try again in a bit

@corya-akamai
Copy link
Contributor Author

I'm pointing at the dev environment and have the Managed Databases Beta account capability, but I'm seeing the error below whenever I try to get on the DBaaS landing page -- is this happening for others as well?

Screenshot 2024-09-24 at 2 01 40 PM

Also running into issues with provisioning DBs in alpha at the moment, will try again in a bit

The BE is currently failing for me in alpha too

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observing akmadmin & read-only host

@abailly-akamai abailly-akamai merged commit b1e9370 into linode:develop Sep 25, 2024
19 of 20 checks passed
@corya-akamai corya-akamai deleted the UIE-8007 branch September 26, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants