feat: [UIE-8129] - IAM RBAC add new user permissions api #11146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
requested review from
jaalah-akamai and
abailly-akamai
and removed request for
a team
aaleksee-akamai
force-pushed
the
UIE-8129-iam-rbac-new-permissions-api
branch
from
a36779f to
39e52b6
Compare
aaleksee-akamai
changed the title
|
Coverage Report: ✅ |
aaleksee-akamai
changed the title
cpathipa
requested review from
cpathipa and
jaalah-akamai
and removed request for
jaalah-akamai and
cpathipa
aaleksee-akamai
force-pushed
the
UIE-8129-iam-rbac-new-permissions-api
branch
2 times, most recently
from
e3cd319 to
886495c
Compare
packages/api-v4/src/iam/types.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export interface UserPermissions { | |||
| account_access: string[]; | |||
There was a problem hiding this comment.
It will very much help in the short and long terms to type the account_access, resource_type and roles properties with unions. Doing this from the start will help development - we can add a couple and adding/modifying them as we go -
There was a problem hiding this comment.
Thanks @abailly-akamai , I've updated types with unions
packages/api-v4/src/iam/types.ts
Outdated
| export interface ResourceAccess { | ||
| resource_id: number; | ||
| resource_type: string; | ||
| roles: string[]; |
packages/api-v4/src/iam/types.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export interface UserPermissions { | |||
There was a problem hiding this comment.
@aaleksee-akamai any thoughts on naming conventions here? Am wondering if the term iam could be baked into our core types.
I can see UserPermissions cognitively conflicting with legacy Permissions. Maybe prefixing those? ex: IamUserPermissions
There was a problem hiding this comment.
@abailly-akamai , done
aaleksee-akamai
force-pushed
the
UIE-8129-iam-rbac-new-permissions-api
branch
from
886495c to
a34c725
Compare
aaleksee-akamai
force-pushed
the
UIE-8129-iam-rbac-new-permissions-api
branch
from
a34c725 to
9336317
Compare
Cloud Manager UI test results🎉 445 passing tests on test run #6 ↗︎
|
abailly-akamai
approved these changes
Nov 8, 2024
12 tasks
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 33m 37s |
| Commit |
|
| Committer | aaleksee-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
IAM RBAC - new api for user permissions
Changes 🔄
Target release date 🗓️
Nov 12, 2024 (dev)
As an Author I have considered 🤔
Check all that apply