-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [M3-8786] - Update and clean up @types/node
package
#11157
chore: [M3-8786] - Update and clean up @types/node
package
#11157
Conversation
@@ -57,7 +57,6 @@ | |||
"lib" | |||
], | |||
"devDependencies": { | |||
"@types/node": "^12.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe api-v4
, validation
, and ui
don't need @types/node
. These packages are intended to run in any environment / JS runtime and the source code don't use any Node.js specific features so I think we can remove the dependency.
The manager repo needs @types/node
because we have scripts that use things like Node's "fs"
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Banks!
✅ not seeing any changes with the SessionExpirationDialog that uses useInterval
✅ general spot check of CM
Description 📝
18.14
to20.17
#10866@types/node
version to match our Node.js version 📦 It seems to not have been kept up to date@types/node
from our packages that don't need Node.js types 🧹How to test 🧪
As an Author I have considered 🤔