test: [M3-8890] - Fix flaky DBaaS resize test related to recent factory changes #11238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
AzureLatte
and removed request for
a team
…d succeed on second
jdamore-linode
requested review from
mjac0bs and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 445 passing tests on test run #6 ↗︎
|
bnussman-akamai
approved these changes
Nov 12, 2024
mjac0bs
added
Approved
hkhalil-akamai
approved these changes
Nov 12, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 24s |
| Commit |
|
| Committer | jdamore-linode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
santoshp210-akamai
pushed a commit
to santoshp210-akamai/manager
that referenced
this pull request
Nov 14, 2024
…ry changes (linode#11238) * Set DBaaS resize test mock database instance platform to `'rdbms-legacy'` * Added changeset: Fix DBaaS resize tests that fail on first attempt and succeed on second
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a few flaky tests in
resize-database.spec.tsthat fail on their first attempt and succeed on their second.I believe this was caused by recent changes to our
databaseFactory'splatformfield. Because the Cypress tests pre-date that field, it inherits the default value from the factory, which is always set to'rdbms_default'on the first test attempt and'rdbms_legacy'on the second attempt.Because the new DBaaS v2 changes introduce a couple changes to the resize flow, the tests fail when the value is set to
'rdbms_default', so this PR resolves the test by ensuring the mock database'splatformis'rdbms_legacy'.Changes 🔄
'rdbms_legacy'Target release date 🗓️
N/A
How to test 🧪
As an Author I have considered 🤔
Check all that apply