change: [DI-22390] - Enhanced monitor page for contextual view #11388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhagra-akamai
requested review from
abailly-akamai and
harsh-akamai
and removed request for
a team
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Dec 12, 2024
Comment on lines
305
to
311
| <KeyboardArrowDownIcon | ||
| sx={{ color: 'grey', height: '30px', width: '30px' }} | ||
| /> | ||
| ) : ( | ||
| <KeyboardArrowRightIcon | ||
| sx={{ color: 'grey', height: '30px', width: '30px' }} | ||
| /> |
There was a problem hiding this comment.
sx prop isn't doing anything here since these are not components or styled components. I wonder if we even need these styles? We most likely could remove them
|
@jaalah-akamai thanks for approval. Due to recent mockup change suggested by UX, I marking this PR as draft until changes are done according the updated mockup |
Cloud Manager UI test results🎉 466 passing tests on test run #6 ↗︎
|
nikhagra-akamai
changed the title
nikhagra-akamai
changed the title
nikhagra-akamai
changed the title
|
@jaalah-akamai @abailly-akamai @harsh-akamai I've updated the PR with latest mockup provided by UX and it is ready for review. Please check |
abailly-akamai
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
@nikhagra-akamai PR looks good
Can you confirm we want the default state to show the filter select rather than the filter tag list?
Yes default state is the filter select |
jaalah-akamai
approved these changes
Dec 18, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 35s |
| Commit |
|
| Committer | Nikhil Agrawal |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
469
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…e#11388) * change: [DI-22125] - Moved time range select outside the paper in contextual view * change: [DI-22125] - Moved duplicate code into utils * change: [DI-22125] - Added test cases * change: [DI-22125] - Added default label to contextual view * Added changeset * change: [DI-22125] - Updated mock data * upcoming: [DI-22125] - Updated logic to hide label in contextual view * upcoming: [DI-22125] - Removed hide label from global filters * change: [DI-22390] - Added disabled dashboard select in contextual view * change: [DI-22390] - Updated test cases * change: [DI-22125] - Updated styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Enhanced the monitor page for contextual view as per the latest figma https://www.figma.com/design/uvdOz9Xs0RVdMRJMCIgS9H/ACLP---Contextual-views?node-id=12209-52065&t=4mG9hXqZrRpancpc-0
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
20th Dec 2024
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅