Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI-23201 : Add scaffolding for new edit resource component for system alerts in CloudPulse alerting #11583

Merged

Conversation

venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Jan 29, 2025

Description 📝

Add the ability to edit the resources associated with the system alerts.

Changes 🔄

  1. Add new endpoint for editing resources associated with alerts in apiV4.
  2. Add new action item Edit for system alerts.
  3. New component for editing alerts resources.
  4. Enhanced AlertResources component to have checkboxes and publish the selections.
  5. Add UTs for the respective changes.

Note: This PR doesn't have entire edit functionality, it has the skeleton for edit resources component that keeps track of the selected resources alone, the PUT call and other functionalities will be implemented in part 2 PR to keep this Pr small.

Target release date 🗓️

11-02-2025

Preview 📷

Before After
Screenshot 2025-01-29 at 9 14 46 PM Screenshot 2025-01-29 at 9 14 57 PM
Screenshot 2025-01-29 at 9 22 46 PM Screenshot 2025-01-29 at 9 38 21 PM
Screenshot 2025-01-29 at 9 38 41 PM

How to test 🧪

  1. Login as mock as some of the endpoints are not available.
  2. Navigate to Monitor tab and then to Alerts.
  3. Select a dbaas related alert (mocks are good here) and if you find Edit(only for system alerts) click on that.
  4. You will be able to see the changes
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai venkymano-akamai marked this pull request as ready for review January 30, 2025 14:09
@venkymano-akamai venkymano-akamai requested a review from a team as a code owner January 30, 2025 14:09
@venkymano-akamai venkymano-akamai removed the request for review from a team January 30, 2025 14:09
Copy link

github-actions bot commented Jan 30, 2025

Coverage Report:
Base Coverage: 79.28%
Current Coverage: 79.28%

Copy link
Contributor

@santoshp210-akamai santoshp210-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@venkymano-akamai
Copy link
Contributor Author

@cpathipa / @hana-akamai , This is ready for review

@venkymano-akamai venkymano-akamai added the Add'tl Approval Needed Waiting on another approval! label Feb 3, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #12 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing493 Passing2 Skipped109m 2s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Feb 3, 2025
@jaalah-akamai jaalah-akamai merged commit b1bf01f into linode:develop Feb 3, 2025
22 of 23 checks passed
Copy link

cypress bot commented Feb 3, 2025

Cloud Manager E2E    Run #7162

Run Properties:  status check passed Passed #7162  •  git commit b1bf01f0fb: DI-23201 : Add scaffolding for new edit resource component for system alerts in ...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7162
Run duration 30m 18s
Commit git commit b1bf01f0fb: DI-23201 : Add scaffolding for new edit resource component for system alerts in ...
Committer venkatmano-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 495
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants