-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-9092] - Add Feature Flag for Linode Interfaces #11584
feat: [M3-9092] - Add Feature Flag for Linode Interfaces #11584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the API is currently returning I didn't add the flag to Launch Darkly yet just incase we wanted something different than |
Coverage Report: ✅ |
ooh a reference to Enhanced Interfaces still exists 😆 |
Great, thank you! @coliu-akamai |
Cloud Manager UI test results🎉 490 passing tests on test run #4 ↗︎
|
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 29m 11s |
Commit |
|
Committer | Banks Nussman |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
2
|
|
0
|
|
493
|
View all changes introduced in this branch ↗︎ |
update - they said it will be changed to 'Linode Interfaces' around hopefully next week or so. There's a number of other API clarifications, so gonna make a ticket to follow up on them in [M3-9210] |
Description 📝
BaseFeatureFlag
for now, but we will likely extendBaseFeatureFlag
with more properties as this project evolvesuseIsLinodeInterfacesEnabled
hook 🎣Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅