Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-9092] - Add Feature Flag for Linode Interfaces #11584

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jan 29, 2025

Description 📝

  • Adds a feature flag for the Linode Interfaces project 🔌 🏴
    • The flag is just a BaseFeatureFlag for now, but we will likely extend BaseFeatureFlag with more properties as this project evolves
  • Adds initial useIsLinodeInterfacesEnabled hook 🎣
    • This is just acts as a useful abstraction over the flag and customer tags
  • Opening this PR now so that we can begin building out the UI behind a flag

Preview 📷

Screenshot 2025-01-29 at 12 06 18 PM

How to test 🧪

  • Nothing to test in the UI! Just verify the code looks correct and doesn't make any crazy errors
  • Verify the unit test brings value
    • It is basic for now, but it will be nice to have once this project gets a bit more complex
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai self-assigned this Jan 29, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 29, 2025 17:08
@bnussman-akamai bnussman-akamai requested review from hana-akamai and cpathipa and removed request for a team January 29, 2025 17:08
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed tests pass - thank you!

We'll want to update the GET v4/regions/{id} endpoint too as part of the AC:

not urgent, does the feature flag need to be turned on in dev in launch darkly? Not seeing it when I console.logged flags in useFlags():

image

@bnussman-akamai
Copy link
Member Author

@coliu-akamai

I see the API is currently returning Enhanced Interfaces on /v4/regions right now. I added that. We may need to update this if they every change it to just Interfaces

I didn't add the flag to Launch Darkly yet just incase we wanted something different than linodeInterfaces. I will add it when merging

Copy link

github-actions bot commented Jan 29, 2025

Coverage Report:
Base Coverage: 79.29%
Current Coverage: 79.3%

@coliu-akamai
Copy link
Contributor

ooh a reference to Enhanced Interfaces still exists 😆
I'll leave a comment on the region endpoint to give them a heads up

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 29, 2025
@bnussman-akamai
Copy link
Member Author

Great, thank you! @coliu-akamai

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 490 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing490 Passing2 Skipped119m 40s

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 29, 2025
@bnussman-akamai bnussman-akamai merged commit 1ef473f into linode:develop Jan 30, 2025
23 checks passed
Copy link

cypress bot commented Jan 30, 2025

Cloud Manager E2E    Run #7151

Run Properties:  status check passed Passed #7151  •  git commit 1ef473ff35: feat: [M3-9092] - Add Feature Flag for Linode Interfaces (#11584)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7151
Run duration 29m 11s
Commit git commit 1ef473ff35: feat: [M3-9092] - Add Feature Flag for Linode Interfaces (#11584)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 493
View all changes introduced in this branch ↗︎

@coliu-akamai
Copy link
Contributor

coliu-akamai commented Jan 30, 2025

update - they said it will be changed to 'Linode Interfaces' around hopefully next week or so. There's a number of other API clarifications, so gonna make a ticket to follow up on them in [M3-9210]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Linode Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants