fix: Update LKE Tiered Version endpoints #11703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
hasyed-akamai,
bill-akamai and
mjac0bs
and removed request for
a team
jdamore-linode
previously approved these changes
Feb 21, 2025
There was a problem hiding this comment.
I think we want to update the Cypress intercept util for this endpoint too: https://github.com/linode/manager/blob/develop/packages/manager/cypress/support/intercepts/lke.ts#L80
Approved pending that + automated test results
mjac0bs
previously approved these changes
Feb 21, 2025
coliu-akamai
dismissed stale reviews from mjac0bs and jdamore-linode
via
8d0e2c1
coliu-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
|
thanks Joe and Mariah, just pushed up the change - will need a rereview |
jdamore-linode
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks for responding to and tackling this so quickly @coliu-akamai! Approved pending test results
mjac0bs
approved these changes
Feb 21, 2025
|
Coverage Report: ✅ |
bill-akamai
approved these changes
Feb 21, 2025
|
🚀 |
Cloud Manager UI test results🎉 521 passing tests on test run #3 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
staging
|
| Run status |
|
| Run duration | 32m 16s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
521
|
| View all changes introduced in this branch ↗︎ | |
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Feb 26, 2025
* Update LKE Tiered Version endpoints * update cypress test util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates LKE tiered version endpoints to match new API changes (see internal slack thread / apinext pr 7547 for details)
Target release date 🗓️
2/25
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅