chore: [M3-9440] - Improve Banner Spacing #11724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
mjac0bs and
pmakode-akamai
and removed request for
a team
bnussman-akamai
commented
Feb 25, 2025
| @@ -143,7 +143,7 @@ export const Notice = (props: NoticeProps) => { | |||
| marginBottom: | |||
| spacingBottom !== undefined | |||
| ? `${spacingBottom}px` | |||
| : theme.spacing(3), | |||
| : theme.spacing(1), | |||
There was a problem hiding this comment.
This does affect all notices throughout the application unless they specify a spacingBottom manually.
Ideally, our components don't have any spacing by default and the spacing is up to the component that contains the Notice, but I don't want to make such a big breaking change right now
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Can we get a Jira ticket and a changeset for this one? Ticket may be slightly pedantic for a 3 line change, but Makes a global change to our banner is best if it's easily trackable.
Pending that feedback, I think this does improve the spacing in the UI for the better. Clicked around through various products to trigger notices and didn't see any glaring regressions. 👍🏼
mjac0bs
added
Missing Changeset
Add'tl Approval Needed
bnussman-akamai
changed the title
Cloud Manager UI test results🎉 530 passing tests on test run #5 ↗︎
|
pmakode-akamai
approved these changes
Feb 27, 2025
pmakode-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 09s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
530
|
| View all changes introduced in this branch ↗︎ | |
aaleksee-akamai
pushed a commit
to aaleksee-akamai/manager
that referenced
this pull request
Feb 27, 2025
* improve-banner-spacing * update test * add changeset --------- Co-authored-by: Banks Nussman <[email protected]>
aaleksee-akamai
pushed a commit
to aaleksee-akamai/manager
that referenced
this pull request
Feb 28, 2025
* improve-banner-spacing * update test * add changeset --------- Co-authored-by: Banks Nussman <[email protected]>
aaleksee-akamai
pushed a commit
to aaleksee-akamai/manager
that referenced
this pull request
Feb 28, 2025
* improve-banner-spacing * update test * add changeset --------- Co-authored-by: Banks Nussman <[email protected]>
aaleksee-akamai
pushed a commit
to aaleksee-akamai/manager
that referenced
this pull request
Feb 28, 2025
* improve-banner-spacing * update test * add changeset --------- Co-authored-by: Banks Nussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅