Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cypress tests in GitHub Actions (again) #11754

Merged

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Feb 27, 2025

Description 📝

@bnussman-akamai bnussman-akamai added the github_actions Pull requests that update GitHub Actions code label Feb 27, 2025
@bnussman-akamai bnussman-akamai self-assigned this Feb 27, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner February 27, 2025 17:54
@bnussman-akamai bnussman-akamai requested review from coliu-akamai and bill-akamai and removed request for a team February 27, 2025 17:54
Copy link

github-actions bot commented Feb 27, 2025

Coverage Report:
Base Coverage: 80.18%
Current Coverage: 80.18%

@@ -35,7 +35,6 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: "20.17"
cache: "pnpm"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're just not going to cache dependencies. This is what Cypress recommends here.

I tried this approach, but it didn't work, so we'll just keep it simple for now. (This is how we were doing it with yarn anyway)

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 530 passing tests on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing530 Passing3 Skipped100m 57s

@bnussman-akamai bnussman-akamai merged commit 3a536ea into linode:develop Feb 27, 2025
24 checks passed
Copy link

cypress bot commented Feb 27, 2025

Cloud Manager E2E    Run #7312

Run Properties:  status check passed Passed #7312  •  git commit 3a536eab5b: fix: Cypress tests in GitHub Actions (again) (#11754)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7312
Run duration 35m 17s
Commit git commit 3a536eab5b: fix: Cypress tests in GitHub Actions (again) (#11754)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 530
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants