-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: [M3-9447] - Update react-vnc
for security updates
#11758
Conversation
path-to-regexp
to 0.1.12react-vnc
for security updates
ref.current.rfb._rfbConnectionState !== 'connected' | ||
) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those checks help with seeing the Glish interface sometime reload before being fully available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Verified Glish works as expected. ✅
Lock file diff is unexpectedly large -- I assume this is because react-vnc has many changed dependencies? Or is this something related to pnpm.
It's because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
Coverage Report: ❌ |
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
9c4fca1
to
29dc55f
Compare
Description 📝
🎉 This will resolve
And hopefully burry these
path-to-regex
issues for the foreseeable future 👍Changes 🔄
List any change(s) relevant to the reviewer.
react-vnc
to 3.0.7Target release date 🗓️
3/11/2025
Preview 📷
No visual (or functional) regression should result from this PR
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅