Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-9243] - Added show detail dailog for selected Stackscript #11765

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

PR Description 📝

This PR fixes an issue where the Show Details button for StackScripts was unresponsive when deploying a new Linode using a StackScript. Now, the button works as expected and users can view the StackScript details.

Changes 🔄

  • Fixed the unresponsive Show Details button during the deployment of a new Linode via StackScript.

Target release date 🗓️

N/A

Before After
before.mov
after.mov
Before After

Verification steps

  • Verify the Show Details button is responsive during deployment.
  • Confirm that StackScript details display correctly after clicking "Show Details."
  • Verify that for loading state we have added a TableRowLoading
  • Verify there is no line gap in border of TableBody
Author Checklists
  • All unit tests are passing
  • TypeScript compilation succeeded
  • Code passes all linting rules

@hasyed-akamai hasyed-akamai added Bug Fixes for regressions or bugs StackScripts relates to StackScripts labels Feb 28, 2025
@hasyed-akamai hasyed-akamai self-assigned this Feb 28, 2025
@hasyed-akamai hasyed-akamai marked this pull request as ready for review February 28, 2025 18:08
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner February 28, 2025 18:08
@hasyed-akamai hasyed-akamai requested review from hana-akamai and carrillo-erik and removed request for a team February 28, 2025 18:08
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing530 Passing3 Skipped105m 39s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config
timerange-verification.spec.tsIntegration tests for verifying Cloudpulse custom and preset configurations » Implement and validate the functionality of the custom date and time picker for selecting a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs Ready for Review StackScripts relates to StackScripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants