Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: [M3-9457] - Update jspdf dependencies to resolve DOMPurify dependabot alert #11768

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Preview 📷

Before After
Screenshot 2025-02-28 at 3 44 54 PM Screenshot 2025-02-28 at 3 44 07 PM

How to test 🧪

  • Verify invoice and payments PDFs generated by Cloud Manager contain the correct information and have correct formatting (viewable on the http://localhost:3000/account/billing page)
    • Compare with prod and look for regressions in the PDFs
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Feb 28, 2025
@bnussman-akamai bnussman-akamai self-assigned this Feb 28, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner February 28, 2025 20:50
@bnussman-akamai bnussman-akamai requested review from mjac0bs and harsh-akamai and removed request for a team February 28, 2025 20:50
Copy link

Coverage Report:
Base Coverage: 80.17%
Current Coverage: 80.17%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #1 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing530 Passing3 Skipped130m 0s

Details

Failing Tests
SpecTest
open-support-ticket.spec.tsopen support tickets » can create a support ticket with an entity
timerange-verification.spec.tsIntegration tests for verifying Cloudpulse custom and preset configurations » Implement and validate the functionality of the custom date and time picker for selecting a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants