chore: [M3-6232] - Update VolumeStatus type and logic
#8862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
@linode/api-v4
mjac0bs
reviewed
Mar 9, 2023
| @@ -19,10 +19,8 @@ export type VolumeStatus = | |||
| | 'creating' | |||
| | 'active' | |||
| | 'resizing' | |||
| | 'deleting' | |||
| | 'deleted' | |||
| | 'migrating' | |||
There was a problem hiding this comment.
Are status of migrating and offline just not documented in the API docs? The only statuses I saw in the enum were creating, active, and resizing, though I may have missed something.
I was curious when a volume would return a status of migrating; I had tried to migrate a Linode with an attached volume, the message said
There was a problem hiding this comment.
You're right. The API docs are wrong here. I test against my local API to verify what the API may actually return.
The status of migrating is left over from the HDD to NVME migration but is still possible from a technical perspective
There was a problem hiding this comment.
Got it, thanks for clarifying!
mjac0bs
approved these changes
Mar 9, 2023
dwiley-akamai
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪
yarn test volumeTurn on the MSW to see all of the possible volume statuses on
/volumes