-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for self serve betas endpoints #9386
feat: Add support for self serve betas endpoints #9386
Conversation
1 flaky tests on run #4873 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
object storage failure paths > shows error upon object upload failure |
Output
Screenshots
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
@CodyFinn-Akamai looks good! Just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, made some comments for cleanup and to bring things in line with our current RQ patterns
Adds support for the self serve beta endpoints by: * Adding endpoint wrapper functions in api-v4 package * Adding factories for betas and account betas * Adding server handlers for betas and account betas endpoints * Adding queries for betas and account betas
Co-authored-by: Dajahi Wiley <[email protected]>
Co-authored-by: Dajahi Wiley <[email protected]>
7650e1c
to
608a0ac
Compare
@CodyFinn-Akamai this is looking good, there's a few pending comments from @dwiley-akamai remaining, otherwise GTG! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two other minor comments but this is good to go aside from those
Co-authored-by: Dajahi Wiley <[email protected]>
Co-authored-by: Dajahi Wiley <[email protected]>
Description 📝
Adds support for the self serve beta endpoints by:
Major Changes 🔄
List highlighting major changes
How to test 🧪