feat: Allow NodeBalancer creation without config #9472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
approved these changes
Aug 1, 2023
bnussman-akamai
added
Add'tl Approval Needed
|
@bnussman I am not sure why the CI is failing... Should I fix it or it's something unrelated? I can't see the details of the CI run neither. |
|
@zliang-akamai Don't worry about that check that is failing. Our e2e tests only run for members of our team. It's not really a failure. It's just failing due to a lack of permissions. Your PR passes all of our other checks and our UX team is good with your changes! ✅ |
bnussman-akamai
added
Approved
|
@bnussman-akamai Thanks for generating the change set for this PR, sorry about didn't realize it was needed 😅 And since I don't have the write access to this repo, can you help me to merge it if it's fully approved? Thank you! |
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Allow node balancer creation without config * Added changeset: NodeBalancers can be created without a configuration --------- Co-authored-by: Banks Nussman <[email protected]>
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Allow node balancer creation without config * Added changeset: NodeBalancers can be created without a configuration --------- Co-authored-by: Banks Nussman <[email protected]>
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Allow node balancer creation without config * Added changeset: NodeBalancers can be created without a configuration --------- Co-authored-by: Banks Nussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
A configuration is not strictly required when invoking the NodeBalancer creation API, and only the region is required. I think it would be nicer if we can do the same thing in cloud manager. I think sometimes an user may want to create a nodebalancer and config it later, and this might be able to make their work easier.
I am not familiar with the development of cloud manager, so please feel free to close the PR this change is not desired, or commit to this branch if there is anything else you guys would like to add.
Major Changes 🔄
Preview 📷
How to test 🧪
Not sure