Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: organize PlansPanel component #9486

Merged

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Aug 3, 2023

Description 📝

This organizes the PlansPanel component as a shared component located in features/components/ (FE Cafe item) since it binds with global state.**

Before After
Content Content

How to test 🧪

  • Validate plans table is rendering in Linode and LKE

@cpathipa cpathipa self-assigned this Aug 3, 2023
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plans panel looks good on Linode/Kubernetes/DB create flows. 🚢

The merge conflict to resolve looks like a file that slipped in with linting changes not relevant to this PR.

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 3, 2023
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 3, 2023
@cpathipa cpathipa merged commit 04a4cfd into linode:develop Aug 4, 2023
@cpathipa cpathipa deleted the M3-6503-organize-PlansPanel-component branch August 4, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Missing Changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants