fix: Capture less Sentry performance data in production #9487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/manager/.changeset/pr-9487-tech-stories-1691069597065.md
Outdated
Show resolved
Hide resolved
Co-authored-by: jdamore-linode <[email protected]>
jdamore-linode
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
We used 100,000 transactions in 5 days with a capture rate of 20%. We need 100,000 transactions to last us 1 month so we need to use a percentage less than ~16%
I'm probably misunderstanding how tracesSampleRate works, so I'm approving this in the meantime -- if a sample rate of 20% causes us to meet our 100,000 transaction limit in 5 days, won't a sample rate of 10% cause us to meet our limit in 10 days?
bnussman-akamai
added
Add'tl Approval Needed
|
Yikes, my fault. How does 2.5% sound? If we capture 2.5% of errors, we'd hit our limit in 40 days @jdamore-linode. |
That sounds like it would work to me! |
jaalah-akamai
approved these changes
Aug 3, 2023
bnussman-akamai
added
Approved
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 7, 2023
* capture `10%` * Added changeset: Decreace Sentry capture rate * Update packages/manager/.changeset/pr-9487-tech-stories-1691069597065.md Co-authored-by: jdamore-linode <[email protected]> * capture 2.5% of transactions --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: jdamore-linode <[email protected]>
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 7, 2023
* capture `10%` * Added changeset: Decreace Sentry capture rate * Update packages/manager/.changeset/pr-9487-tech-stories-1691069597065.md Co-authored-by: jdamore-linode <[email protected]> * capture 2.5% of transactions --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: jdamore-linode <[email protected]>
jaalah-akamai
pushed a commit
that referenced
this pull request
Aug 8, 2023
* capture `10%` * Added changeset: Decreace Sentry capture rate * Update packages/manager/.changeset/pr-9487-tech-stories-1691069597065.md Co-authored-by: jdamore-linode <[email protected]> * capture 2.5% of transactions --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: jdamore-linode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We used 100,000 transactions in 5 days with a capture rate of 20%. We need 100,000 transactions to last us 1 month so we need to use a percentage less than ~3.75%
How to test 🧪