feat: [M3-6787] - Update LKE HA implementation #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
requested review from
jaalah-akamai,
bnussman-akamai,
dwiley-akamai and
cpathipa
|
I had to hardcode one of the colors otherwise it would only work for either of the themes. I also attempted to solve the issue with styled components but the issue persisted. This seems straightforward like the text color on the SearchBar from the other ticket. Maybe @jaalah-akamai can offer some helpful insight into this. |
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
Aug 4, 2023
bnussman-akamai
added
Add'tl Approval Needed
bnussman-akamai
added
Ready for Review
and removed
Add'tl Approval Needed
bnussman-akamai
approved these changes
Aug 10, 2023
bnussman-akamai
added
Add'tl Approval Needed
jdamore-linode
requested changes
Aug 10, 2023
packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/kubernetes/smoke-lke-create.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Show resolved
Hide resolved
|
After discussing the LKE HA pricing variable issue, it was decided that at this time the e2e test coverage for HA Control Plane would be removed. An additional unit test was implemented to help mitigate any loss of coverage. A spike ticket will be created to investigate the |
jdamore-linode
approved these changes
Aug 11, 2023
bnussman-akamai
added
Approved
mjac0bs
added a commit
to mjac0bs/manager
that referenced
this pull request
Aug 18, 2023
This was referenced Aug 21, 2023
mjac0bs
added a commit
that referenced
this pull request
Aug 22, 2023
* Delete unused files from refactor in #9489 * Add dynamic HA pricing for Kubernetes * Update unit tests * Add DC-specific HA price on upgrade dialog * Replace HA env var with pricing constant * Clean up * Added changeset: Add DC-specific pricing to Kubernetes HA * Don't display prices before region is selected * Tweak copy in Kube checkout bar * Update tests * Feature flag all changes and update tests * Update price increase percentage for Sao Paulo * Address feedback: eliminate prop and use hook * Address feedback: copy, UX for HA checkout bar
coliu-akamai
pushed a commit
to coliu-akamai/manager
that referenced
this pull request
Aug 23, 2023
* Delete unused files from refactor in linode#9489 * Add dynamic HA pricing for Kubernetes * Update unit tests * Add DC-specific HA price on upgrade dialog * Replace HA env var with pricing constant * Clean up * Added changeset: Add DC-specific pricing to Kubernetes HA * Don't display prices before region is selected * Tweak copy in Kube checkout bar * Update tests * Feature flag all changes and update tests * Update price increase percentage for Sao Paulo * Address feedback: eliminate prop and use hook * Address feedback: copy, UX for HA checkout bar
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* Delete unused files from refactor in linode#9489 * Add dynamic HA pricing for Kubernetes * Update unit tests * Add DC-specific HA price on upgrade dialog * Replace HA env var with pricing constant * Clean up * Added changeset: Add DC-specific pricing to Kubernetes HA * Don't display prices before region is selected * Tweak copy in Kube checkout bar * Update tests * Feature flag all changes and update tests * Update price increase percentage for Sao Paulo * Address feedback: eliminate prop and use hook * Address feedback: copy, UX for HA checkout bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Replaces the former HA Checkbox with a Radio Group and moves the HA Control Plane away from the KubeCheckoutBar into the main content.
Major Changes 🔄
HAControlPlanecomponent consisting of aRadioGroupforcing users to make an active selection for HAHACheckboxcomponent from theKubeCheckoutBarcomponent in the sidebar.Preview 📷
How to test 🧪
kubernetes/createlanding page and inspect for any UI defects.HAControlPlanecomponent.