Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-6668] Broken K8 node pool infinite scrolling #9509

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Aug 7, 2023

## Description 📝

The scrollableAncestor="window" prop on the Waypoint instance was breaking the infinite scrolling for the node pools on a K8 cluster detail. From what I can understand and read, the prop is responsible for:

A custom ancestor to determine if the target is visible in it. This is useful in cases where you do not want the immediate scrollable ancestor to be the container. For example, when your target is in a div that has overflow auto but you are detecting onEnter based on the window.

Which we are not doing at all since our handler is based on a count of node pools.

Removing this prop fixes the issue (loads the next 25 node pools on scroll) and does not appear to introduce any other regression.

How to test 🧪

  1. Pull code locally, and create 10 node pools on a given k8 cluster (no need to test with 25, we just want to test what happens when scrolling past the vertical viewport)
  2. Modify the NodePoolsDisplay count on the default state to 5 so Waypoint can trigger earlier
  3. Confirm you get all 10 node pools displayed once scrolling down (you may not see any loading state but all should be present almost instantly once scrolling down)

@abailly-akamai abailly-akamai self-assigned this Aug 7, 2023
@abailly-akamai abailly-akamai marked this pull request as ready for review August 7, 2023 19:08
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Aug 8, 2023
@abailly-akamai abailly-akamai merged commit d7dcb5f into linode:develop Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants