-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6735] - VPC Edit drawer #9528
feat: [M3-6735] - VPC Edit drawer #9528
Conversation
packages/manager/src/components/EnhancedSelect/variants/RegionSelect/RegionSelect.tsx
Outdated
Show resolved
Hide resolved
I think there are some accessibility and usability issues with the changes involving the tooltip on the disabled select.
I'm also wondering what the motivations are behind this from a design and user experience point of view. I'm guessing it's easier to lay out the form without accounting for the help icon, and may look cleaner aesthetically, but I don't think removing it results in a better experience for our users -- I think the help icon plays an important role by telegraphing to the user that there is additional contextual information available. |
@hana-linode Added an integration test for the VPC landing page edit flow. It confirms that VPC labels and descriptions can be edited and that the page updates to reflect the changes. You can run the tests with this command: yarn cy:run -s "cypress/e2e/core/vpc/vpc-landing-page.spec.ts" |
@jdamore-linode Talked with Andrew and he said we can keep the help icon in light of the issues you mentioned |
This reverts commit 6118880.
Description 📝
Add the ability to edit a VPC
Preview 📷
Screen.Recording.2023-08-09.at.2.52.57.PM.mov
How to test 🧪
Create a VPC via the API, click on the edit button and change the label/description. Check the table/drawer again to ensure it updated