Release v1.99.1 - staging → master #9538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description 📝 Follow up to #9494. The previous PR fixed the Cloud crashing issue, but introduced another issue where we were not unescaping the encoded user data. So, when running the `atob` function on the user data, the output string included `%`s instead of just the original string. reading: https://base64.guru/developers/javascript/examples/unicode-strings https://stackoverflow.com/questions/30631927/converting-to-base64-in-javascript-without-deprecated-escape-call (see the second answer by `T S`) ## How to test 🧪 - Add a console log after line 706 to log the user data `console.log(utoa(this.props.userData))` - Follow the steps in #9494 - Take the result of the console log and run `atob` - The result should be readable and not have unexpected characters such as `%`
Passing run #5005 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
cpathipa
approved these changes
Aug 11, 2023
bnussman-akamai
added
Add'tl Approval Needed
jdamore-linode
approved these changes
Aug 11, 2023
bnussman-akamai
added
Approved
|
@hana-linode I completely overlooked the fact that PRs for long lived branches still run Cypress via GitHub Actions, and since that passed there's no reason to wait for the Jenkins run to finish as well (although it looks like it's about to finish too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.