Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duplicate key error on Linodes Landing #9543

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: Duplicate key error on Linodes Landing #9543

merged 2 commits into from
Aug 14, 2023

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Fixes the duplicate key error when on the Linodes Landing page (and NodeBalancer landing page)

Major Changes 🔄

  • Use lodash instead of ramda tail() function
  • Clean up IPAddress.tsx while fixing the bug

Preview 📷

Before After
Screenshot 2023-08-14 at 11 18 33 AM Screenshot 2023-08-14 at 11 18 19 AM

How to test 🧪

  • Have at least 1 Linode
  • Go to /linodes
  • Verify you don't see a console error about duplicate keys

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Aug 14, 2023
@bnussman-akamai bnussman-akamai self-assigned this Aug 14, 2023
jdamore-linode
jdamore-linode approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Confirmed that the error is gone on the Linodes landing page and NodeBalancer landing page.

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 14, 2023
coliu-akamai
coliu-akamai approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 14, 2023
@bnussman-akamai bnussman-akamai merged commit 22ea0a7 into linode:develop Aug 14, 2023
This was referenced Aug 17, 2023
Merged
Merged
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
@bnussman-akamai @bnussman @corya-akamai
fix: Duplicate key error on Linodes Landing (linode#9543)
d2628f2 
* fix duplicate key error

* Added changeset: Duplicate key error on Linode and NodeBalancer Landing

---------

Co-authored-by: Banks Nussman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jdamore-linode @coliu-akamai @bnussman