Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-7024] - Fix Hively visual regression #9548

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: [M3-7024] - Fix Hively visual regression #9548

merged 2 commits into from
Aug 15, 2023

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Major Changes 🔄

  • Added hideIcon prop to the <Link /> component for special cases like this
    • I probably could have used a plain <a> here but I figured we'd want to use <Link /> for consistency
  • Cleans up styles and fixes UI bug
  • Remove use of makeStyles
  • Removed use of React.FC

Preview 📷

Before After
Screenshot 2023-08-15 at 2 11 15 PM Screenshot 2023-08-15 at 2 11 02 PM

How to test 🧪

  • You can either create a support ticket in the dev environment and respond to yourself OR just manually make this section render by modifying the code
  • Verify that the Hively section looks better!

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Aug 15, 2023
@bnussman-akamai bnussman-akamai self-assigned this Aug 15, 2023
jdamore-linode
jdamore-linode approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Screenshot 2023-08-15 at 2 27 53 PM

Didn't actually click them but confirmed they have target="_blank" as well.

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 15, 2023
hana-akamai
hana-akamai approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂 😐 🙁

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 15, 2023
@bnussman-akamai bnussman-akamai merged commit 8367e9d into linode:develop Aug 15, 2023
This was referenced Aug 17, 2023
Merged
Merged
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
@bnussman-akamai @bnussman @corya-akamai
fix: [M3-7024] - Fix Hively visual regression (linode#9548)
7dbf0dd 
* initial fix

* Added changeset: Hively icons showing external link icons

---------

Co-authored-by: Banks Nussman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jdamore-linode @hana-akamai @bnussman