Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7100] - Add DC-specific pricing to LKE update integration test #9676

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Sep 13, 2023

Description 📝

This PR adds tests to confirm that a kubernetes cluster can resize node pools and add node pools with DC-specific pricing display and calculating correctly. This lacked coverage with unit tests.

Major Changes 🔄

  • On the Kube details page:
    • The total cluster price correctly calculates the DC-specific price.
  • On the Add a Node Pool drawer:
    • Confirms the Node Pools table displays the DC-specific hourly and monthly pricing corresponding to the region the cluster is in.
    • The helper text price takes DC-specific pricing into account.
      On the Resize Pool drawer:
    • The helper text price takes DC-specific pricing into account

How to test 🧪

  1. How to setup test environment?
yarn && yarn build && yarn start:manager:ci
  1. How to run Unit or E2E tests?
yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"

Comment on lines 744 to 751
describe('LKE cluster updates for DC-specific prices', () => {
beforeEach(() => {
mockAppendFeatureFlags({
dcSpecificPricing: makeFeatureFlagData(true),
}).as('getFeatureFlags');
mockGetFeatureFlagClientstream().as('getClientStream');
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 😅

@mjac0bs mjac0bs force-pushed the M3-7100-lke-update-dc-pricing-e2e branch from b351fc3 to e26ff76 Compare September 15, 2023 14:11
@mjac0bs mjac0bs changed the title test: [M3-7100] test: [M3-7100] - Add DC-specific pricing to LKE update integration test Sep 15, 2023
@mjac0bs mjac0bs marked this pull request as ready for review September 15, 2023 14:23
@mjac0bs mjac0bs requested a review from cliu-akamai September 18, 2023 15:59
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mjac0bs!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 19, 2023
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 19, 2023
@mjac0bs mjac0bs merged commit 48a21bc into linode:develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants