-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7100] - Add DC-specific pricing to LKE update integration test #9676
Merged
mjac0bs
merged 9 commits into
linode:develop
from
mjac0bs:M3-7100-lke-update-dc-pricing-e2e
Sep 19, 2023
Merged
test: [M3-7100] - Add DC-specific pricing to LKE update integration test #9676
mjac0bs
merged 9 commits into
linode:develop
from
mjac0bs:M3-7100-lke-update-dc-pricing-e2e
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
744
to
751
describe('LKE cluster updates for DC-specific prices', () => { | ||
beforeEach(() => { | ||
mockAppendFeatureFlags({ | ||
dcSpecificPricing: makeFeatureFlagData(true), | ||
}).as('getFeatureFlags'); | ||
mockGetFeatureFlagClientstream().as('getClientStream'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart 😅
b351fc3
to
e26ff76
Compare
jdamore-linode
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @mjac0bs!
bnussman-akamai
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR adds tests to confirm that a kubernetes cluster can resize node pools and add node pools with DC-specific pricing display and calculating correctly. This lacked coverage with unit tests.
Major Changes 🔄
On the Resize Pool drawer:
How to test 🧪