Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: M3-7106 - Add AGLB Service Target Delete Dialog #9680

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat: M3-7106 - Add AGLB Service Target Delete Dialog #9680

merged 3 commits into from
Sep 19, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Sep 14, 2023 •
edited
Loading

Description 📝

Adds AGLB Service Target Delete Dialog

Preview 📷

Include a screenshot or screen recording of the change

image

How to test 🧪

  1. Turn on the MSW
  2. Navigate tohttp://localhost:3000/loadbalancers/0/service-targets
  3. Validate the delete dialog modal

@cpathipa cpathipa marked this pull request as draft September 14, 2023 20:25
@cpathipa cpathipa self-assigned this Sep 14, 2023
@cpathipa cpathipa added the ACLB Relating to the Akamai Cloud Load Balancer label Sep 14, 2023
@cpathipa cpathipa marked this pull request as ready for review September 15, 2023 20:06
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 18, 2023 16:04
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and abailly-akamai and removed request for a team September 18, 2023 16:04
abailly-akamai
abailly-akamai approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested the dialog - Looks good 👍
  • failing unit tests are unrelated

@jdamore-linode jdamore-linode self-requested a review September 18, 2023 19:31
@cpathipa cpathipa merged commit 7fa11e5 into linode:develop Sep 19, 2023
@cpathipa cpathipa deleted the M3-7106 branch September 19, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@cliu-akamai cliu-akamai Awaiting requested review from cliu-akamai cliu-akamai is a code owner automatically assigned from linode/frontend

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode

Assignees

@cpathipa cpathipa

Labels
ACLB Relating to the Akamai Cloud Load Balancer Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpathipa @bnussman-akamai @abailly-akamai @bnussman