Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-7156] - TPAProviders invalid prop on a DOM element console errors #9698

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: [M3-7156] - TPAProviders invalid prop on a DOM element console errors #9698

merged 2 commits into from
Sep 20, 2023

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Cleans up 2️⃣ console errors on http://localhost:3000/profile/auth

Major Changes 🔄

  • Don't forward the edit prop to StyledQuestionContainer's Box
  • Don't forward the isButtonEnabled prop to StyledButton's Button

Preview 📷

Before After
Screenshot 2023-09-19 at 11 28 26 AM Screenshot 2023-09-19 at 11 28 04 AM

How to test 🧪

  • Go to http://localhost:3000/profile/auth and observe the console
  • On develop, you should console errors
  • On this PR, you should see no console errors
  • Verify the provider buttons still work (click Github and Google)
  • Verify you can still edit a security question

@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 19, 2023 15:34
@bnussman-akamai bnussman-akamai self-assigned this Sep 19, 2023
@bnussman-akamai bnussman-akamai requested review from abailly-akamai and tyler-akamai and removed request for a team September 19, 2023 15:34
abailly-akamai
abailly-akamai approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! Looks good and warning gone

Let's include a changeset too?

@mjac0bs mjac0bs self-requested a review September 20, 2023 17:59
mjac0bs
mjac0bs approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for fixing! Confirmed no console errors and I can add & edit security questions and change my login method.

@bnussman-akamai bnussman-akamai merged commit a53c879 into linode:develop Sep 20, 2023
@cpathipa cpathipa mentioned this pull request Sep 29, 2023
Merged
@mjac0bs mjac0bs mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@tyler-akamai tyler-akamai Awaiting requested review from tyler-akamai tyler-akamai is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @mjac0bs @abailly-akamai @bnussman