-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7268] - Unassign multiple Linodes from Subnet #9820
fix: [M3-7268] - Unassign multiple Linodes from Subnet #9820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hana! 🚀
Confirmed the following flows:
✅ Confirm that you are able to select Linodes as normal and then click Unassign Linodes
✅ Confirm that the Subnet table removes the unassigned Linodes
✅ Confirm that the inline singular Unassign Linode still works as expected
packages/manager/src/features/VPCs/VPCDetail/SubnetUnassignLinodesDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Able to select Linodes as normal and then click Unassign Linodes ✅
Subnet table removes the unassigned Linodes ✅
Inline singular "Unassign Linode" still works as expected ✅
Do we know where along the line the past few weeks this broke?
packages/manager/src/features/VPCs/VPCDetail/SubnetUnassignLinodesDrawer.tsx
Outdated
Show resolved
Hide resolved
@dwiley-akamai yeah, it broke due to this line to remove an unhelpful warning. Interestingly enough, the warning isn't displaying anymore afaik even with the line removed 🤔 https://github.com/linode/manager/pull/9751/files#diff-5ddea0d7689e7ab71d1d46e4ee263ea0ef5bcb7cf1015590705a7971025d4895R306 |
Description 📝
Fix bug where selecting a single Linode in the Unassign Linodes drawer visually selects everything in the dropdown
Preview 📷
unassign.before.mov
unassign.afrer.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply