Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7268] - Unassign multiple Linodes from Subnet #9820

Merged

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Oct 19, 2023

Description 📝

Fix bug where selecting a single Linode in the Unassign Linodes drawer visually selects everything in the dropdown

Preview 📷

Before After
unassign.before.mov
unassign.afrer.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Point to the dev env and ensure your account has vpc customer tags

Reproduction steps

(How to reproduce the issue, if applicable)

  • Ensure you are on the develop branch or the remote dev environment
  • Create a VPC and Subnet if you don't already have one
  • Go to the VPC's details page and assign some Linodes to the Subnet via the kebab action menu in the table
  • Click on Unassign Linodes via the kebab action menu and try to select a Linode
    • You should see that all Linodes are visually selected instead of just the one

Verification steps

(How to verify changes)

  • Confirm that you are able to select Linodes as normal and then click Unassign Linodes
  • Confirm that the Subnet table removes the unassigned Linodes
  • Confirm that the inline singular Unassign Linode still works as expected

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the VPC Relating to VPC project label Oct 19, 2023
@hana-akamai hana-akamai self-assigned this Oct 19, 2023
@hana-akamai hana-akamai marked this pull request as ready for review October 24, 2023 19:23
@hana-akamai hana-akamai requested a review from a team as a code owner October 24, 2023 19:23
@hana-akamai hana-akamai requested review from cpathipa and coliu-akamai and removed request for a team October 24, 2023 19:23
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hana! 🚀

Confirmed the following flows:

✅ Confirm that you are able to select Linodes as normal and then click Unassign Linodes
✅ Confirm that the Subnet table removes the unassigned Linodes
✅ Confirm that the inline singular Unassign Linode still works as expected

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 25, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Able to select Linodes as normal and then click Unassign Linodes ✅
Subnet table removes the unassigned Linodes ✅
Inline singular "Unassign Linode" still works as expected ✅

Do we know where along the line the past few weeks this broke?

@hana-akamai
Copy link
Contributor Author

@dwiley-akamai yeah, it broke due to this line to remove an unhelpful warning. Interestingly enough, the warning isn't displaying anymore afaik even with the line removed 🤔 https://github.com/linode/manager/pull/9751/files#diff-5ddea0d7689e7ab71d1d46e4ee263ea0ef5bcb7cf1015590705a7971025d4895R306

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 26, 2023
@hana-akamai hana-akamai merged commit e780ffc into linode:develop Oct 26, 2023
@hana-akamai hana-akamai deleted the M3-7268-fix-unassign-multiple-linode branch October 26, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants