Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7329] - MUI Migration - SRC > Components > Crumbs #9841

Merged

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Oct 25, 2023

Description 📝

  • MUI migration for the Crumbs component
  • I really want to get this epic done so we can update to React 18 and drop @mui/styles

Changes 🔄

  • Runs codemod on packages/manager/src/components/Breadcrumb/Crumbs.tsx
  • Find and replaces instances of import { useTheme } from '@mui/styles'; to import { useTheme } from '@mui/material'; because we intend to remove @mui/styles at the end of this migration
  • Rewrites Breadcrumb Storybook story because the old one was broken

Preview 📷

Note

No UI changes are expected

before after
Screenshot 2023-10-25 at 3 14 26 PM Screenshot 2023-10-25 at 3 14 32 PM

How to test 🧪

Verification steps

  • Checkout this PR
  • View various Breadcrumbs throughout Cloud Manager
  • Verify Breadcrumbs look identical to what is at https://cloud.linode.com
  • Optional: view the Storybook story

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Oct 25, 2023
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 25, 2023 19:16
@bnussman-akamai bnussman-akamai requested review from hana-akamai and cpathipa and removed request for a team October 25, 2023 19:16
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! verified Breadcrumbs and no regressions found.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crumbs looked good throughout Cloud! 🍪

Left a couple of minor, non-blocking things.

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants