-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-6937] - Add the ability to scale up DBaaS #9869
feat: [UIE-6937] - Add the ability to scale up DBaaS #9869
Conversation
5c4bcf3
to
f45a915
Compare
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Outdated
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Outdated
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening up this PR -- I did an initial look-over and left some comments.
The tablet view could use some attention, the formatting gets distorted at certain viewport widths:
Video
Screen.Recording.2023-11-06.at.11.49.48.AM.mov
Also, as the video shows, I don't actually see any plans show up, and there's no region selector anywhere. This is an Atlanta database.
packages/manager/.changeset/pr-9869-tech-stories-1699013625860.md
Outdated
Show resolved
Hide resolved
packages/manager/.changeset/pr-9869-tech-stories-1699013625860.md
Outdated
Show resolved
Hide resolved
packages/manager/.changeset/pr-9869-tech-stories-1699013625860.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
That might have been the case. You can try it now in dev environment. |
Just wanted to give a heads up that this PR won’t make it into Cloud Manager’s Monday (1/8/2024) production release. We’ll keep working to get the PR in a mergeable state so that it can be included in the following release (1/22). |
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Outdated
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUp.tsx
Outdated
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseScaleUp/DatabaseScaleUpCurrentConfiguration.tsx
Outdated
Show resolved
Hide resolved
PR is looking solid on my end! Is there any reason not to turn the feature on in production now so we can test this PR against the production environment? |
@bnussman-akamai - There were API changes required for this feature due to which we thought of introducing feature flag. I don't have an update yet whether those changes are available in production environment. If the changes are ready, then we can test in production environment as well. I hope that shouldn't be a blocker to merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes!
This is good to go as far I am concerned
- UI is consistent with Cloud Manager and responsive ✅
- Code looks good ✅
- Feature works as expected in DEV environment ✅
@grevanak-akamai Please let the team know in our channel when you plan on turning this on in Production so we can test things locally before doing so.
Providing my final review right now 👀 You can expect this to be included in our next release (1/22/2024) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description 📝
Add the ability to scale up DBaaS (e.g. from 4GB to 6GB).
Changes 🔄
Preview 📷
Prerequisites
Verification steps
As an Author I have considered 🤔