feat: [M3-7390] - Add AGLB protocol to Service Targets
#9891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teServiceTargetSchema` and `UpdateServiceTargetSchema`
bnussman-akamai
requested review from
dwiley-akamai,
coliu-akamai,
mjac0bs and
cpathipa
and removed request for
a team
dwiley-akamai
approved these changes
Nov 9, 2023
packages/manager/.changeset/pr-9891-upcoming-features-1699549397674.md
Outdated
Show resolved
Hide resolved
mjac0bs
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Service target protocol is visible in table and in the drawer when adding or editing a service target. 🚢
When we've added table columns, we'd forgotten to update the error state of the table, so we're a couple columns short, I noticed when blocking GET service-targets network requests. I made the suggestions to fix that.
| @@ -167,49 +180,13 @@ export const LoadBalancerServiceTargets = () => { | |||
| {error && <TableRowError colSpan={6} message={error?.[0]?.reason} />} | |||
There was a problem hiding this comment.
Suggested change
| {error && <TableRowError colSpan={6} message={error?.[0]?.reason} />} | |
| {error && <TableRowError colSpan={8} message={error?.[0]?.reason} />} |
| @@ -167,49 +180,13 @@ export const LoadBalancerServiceTargets = () => { | |||
| {error && <TableRowError colSpan={6} message={error?.[0]?.reason} />} | |||
| {data?.results === 0 && <TableRowEmpty colSpan={6} />} | |||
There was a problem hiding this comment.
Suggested change
| {data?.results === 0 && <TableRowEmpty colSpan={6} />} | |
| {data?.results === 0 && <TableRowEmpty colSpan={8} />} |
There was a problem hiding this comment.
Any discrepancies with ca_certificate still in the API spec are because changes are not fully reflected there, correct? (Can we request that they fix?)
cpathipa
approved these changes
Nov 10, 2023
| @@ -0,0 +1,54 @@ | |||
| import type { ServiceTargetPayload } from '@linode/api-v4'; | |||
There was a problem hiding this comment.
Any thoughts in naming this file as constants instead of utils ?
coliu-akamai
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds
protocolsupport to AGLB certificates based on a change to the API. This PR also makes other Service Target related changes/fixesChanges 🔄
protocolfield to Service Targetsca_certificate➡️certificate_idbased on API changePreview 📷
How to test 🧪
Prerequisites
Verification steps
Protocolnow shows in the tableAs an Author I have considered 🤔