Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: Update useAccountAvailabilitiesQuery query to use getAll #9907

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 15, 2023

Description 📝

  • Forgot to do this in the original PR 😅 , but basically just making our existing query for useAccountAvailabilitiesQuery use getAll

How to test 🧪

Verification steps

(How to verify changes)

  • Verify that data still looks as expected when using this query and that pagination is gone

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the DC Get Well Relating to the DC Get Well project label Nov 15, 2023
@coliu-akamai coliu-akamai self-assigned this Nov 15, 2023
@coliu-akamai coliu-akamai changed the title upcoming: Update GET account/availabilities query to use getAll upcoming: Update useAccountAvailabilitiesQuery query to use getAll Nov 15, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 15, 2023 19:14
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 15, 2023 19:14
@coliu-akamai coliu-akamai requested review from bnussman-akamai and abailly-akamai and removed request for a team November 15, 2023 19:14
@coliu-akamai coliu-akamai merged commit 88536a5 into linode:develop Nov 15, 2023
@coliu-akamai coliu-akamai deleted the getAll-dcgetwell-endpoint branch November 15, 2023 21:47
@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC Get Well Relating to the DC Get Well project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants