Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7451] - Replace Images landing page section title with "Getting Started Guides" #9930

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

Fixes a typo on the Images landing page empty state by replacing "DNS Manager Guides" with "Getting Started Guides"

Changes 🔄

  • Just replaces "DNS Manager Guides" with "Getting Started Guides"

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before After
📷 📷

How to test 🧪

Not covered by any E2E tests right now (see M3-7452, however). Can be tested manually by navigating to /images and confirming page title. This may require deleting the images on your test account, or using MSW to mock your images request to force the empty state.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe. Good find 🔎

@jdamore-linode jdamore-linode added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Nov 22, 2023
@jdamore-linode jdamore-linode merged commit c491c49 into linode:develop Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants