Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libibumad: Change find_preffered_port #1554

Merged

Conversation

mazorasaf
Copy link
Contributor

@mazorasaf mazorasaf commented Jan 29, 2025

Updated the find_preferred_port function to ensure the same port number is set for SMI/GSI
devices when they belong to the same device.
This prevents selecting different ports for the same device.

@rleon
Copy link
Member

rleon commented Feb 2, 2025

We use kernel coding style for commits.

Please use Subject in title, add description and Fixes line.
Right now, the patch looks:

Subject: [PATCH] libibumad: Change find_preffered_port to set same portnum for
smi/gsi device in case that its the same device (otherwise we might choose
different port for same device)

Signed-off-by: Asaf Mazor [email protected]

@mazorasaf mazorasaf force-pushed the fix_preffered_port_for_multiport_CA branch from e0ab872 to 65f6d46 Compare February 2, 2025 11:03
@rleon
Copy link
Member

rleon commented Feb 4, 2025

Same comments as in PR #1555

@mazorasaf mazorasaf force-pushed the fix_preffered_port_for_multiport_CA branch from 65f6d46 to 14080d0 Compare February 4, 2025 09:36
Updated the find_preferred_port function to ensure the same port number is set for SMI/GSI
devices when they belong to the same device.
This prevents selecting different ports for the same device.

Fixes: be54b52 ("libibumad: Add new API to support SMI/GSI seperation")
Signed-off-by: Asaf Mazor <[email protected]>
@mazorasaf mazorasaf force-pushed the fix_preffered_port_for_multiport_CA branch from 14080d0 to 2f31897 Compare February 4, 2025 10:45
@rleon rleon merged commit 1a1b4c8 into linux-rdma:master Feb 4, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants